early_binding pass#193
Open
jpauli wants to merge 1 commit intozendtech:masterfrom
jpauli:class_early_binding_pass
Open
early_binding pass#193jpauli wants to merge 1 commit intozendtech:masterfrom jpauli:class_early_binding_pass
jpauli wants to merge 1 commit intozendtech:masterfrom
jpauli:class_early_binding_pass
Conversation
Contributor
|
Unless I missed something, this assumes that the looked up parent class is the same between all requests, which is not necessarily true. |
Contributor
|
Fixed patch for PHP7, with benchmark results. https://gist.github.com/dstogov/8d5c3224105f77ec4b84 However, I'm not sure if it makes sense to include it. On Wed, Oct 22, 2014 at 11:33 PM, Nikita Popov notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Talked to dmitry about it.
The goal here is to do the early_binding at compile time, for each op_array, when the class_table of each op_array is known.
This pass code binds the inherited class to its parent.
However, this seems to be really really close to what ZEND_DECLARE_INHERITED_CLASS_DELAYED does. It binds the inheritence tree, but at script loading. I didnt know about that when preparing my patch.
It however seems to bug as I get "class Serializable not found" when I run it against an app of mine :-p