Refactor, fixes, and integrate altium-ibom-releaser#2
Refactor, fixes, and integrate altium-ibom-releaser#2StefanRickli wants to merge 5 commits intozharovdv:mainfrom
Conversation
Also, rename state/control getters/setters to clarify the direction of where information comes from and where it goes. Now we got: - SetState_FromParameters - GetParameters_FromState - SetState_FromControls - SetControls_FromState
…cit filename provided During release preparation, PredictOutputFileNames is called once while, somehow, the PcbDoc cannot be accessed. We catch this by just outputting a dummy filename with some debug information. For the output filename prediction: Before, running the script from an output job would predict and generate ".json" etc. Now, it's "iBOM for <PcbDoc Filename>", respectively "iBOM for <PcbDoc Filename>(VariantName)", similar to Altium-native output filenames.
|
Okay, this is as far as the pure refactors and fixes go. |
|
Here's the changes necessary for making invocation of my external application work: Feel free to add it to your project. I can also just leave it in my fork's alternative branch, and update it according to changes in your project. |
|
Huh.... it needs time :) |
|
Hi! All set and done now on my side. I documented the installation and usage of Thanks again for your support. It was a fun project! |
Thanks for you. It was great. Hope merge it ASAP. And finally want to resolve the issue with DNP/Variants. |
2 participants
This is an ongoing pull request and I will keep adding commits today.