fetch upstream #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix ptomasroos#46 - modernize converters code - valueToPosition uses closest index function - improve cWRP to handle min, max properly changes
…vements Improve multislider
…equest ignore termination request
Fix valueToPosition converter
it doesn't work on android in production mode new impl not that easy for dummies like me
return old createArray implementation
Add currentValue prop type to DefaultMarker component.
* Update README.md * Update README.md * Update README.md
The fact that this function is still returning a position when value is undefined was causing me an issue in single slider mode as under some conditions (after changing min and max values) it was setting positionTwo equal to max. I think it's better it returns undefined when value is undefined
…ers. (ptomasroos#191) Co-authored-by: Thiago <thiago@fuze.cc>
Cleaned up indentations while keeping original code style
* Fix ptomasroos#45 * Fix ptomasroos#45 for any value of snapped prop and centralise prettier config * bugfix: add default value to markerSize
…roos#200) * Fix ptomasroos#45 * Fix ptomasroos#45 for any value of snapped prop and centralise prettier config * bugfix: add default value to markerSize * doc: README.md updated
* fix: Reenable allowOverlap for large sliders If your slider goes from, let's say, 0 to 10: - `this.optionsArray = [0, 1, ... 10];` => its length is 11 - however, `this.props.sliderLength` should only be divided by 10 (representing the 10 sections `0-1`, `1-2`, ..., `9-10`) The fix is then simply to replace L56 by ` this.stepLength = this.props.sliderLength / (this.optionsArray.length - 1);` * docs: Explicit the unit used by minMarkerOverlapDistance for more clarity One could think it was about steps
* feat: Allow expressing overlap distance without re-computing stepLength * refactor: Suggest reducing number of ternary conditions
Co-authored-by: Jascha Kanngiesser <jascha.kanngiesser@sap.com>
* * Adding so its possible to show steps - Show step labels - Show step marks on the track - Customizable step labels, prefix and suffix styling et. - Customizable styling for step container, step label and step markers * Adding smooth-snapped * Added docs
* Update README.md * Update README.md
cannot be combined with minMarkerOverlapDistance/minMarkerOverlapStepDistance were interchanged. Readme has now been fixed
Prop disabledMarkerStyle exists in code, yet missing in definitions.
make it so trackStyle prop is respected
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
![llamapreview[bot]](https://avatars.githubusercontent.com/in/1023541?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto Pull Request Review from LlamaPReview
Large PR Notification
Dear contributor,
Thank you for your substantial contribution to this project. LlamaPReview has detected that this Pull Request contains a large volume of changes, which exceeds our current processing capacity.
Details:
- PR and related contents total size: Approximately 66,042 characters
- Current limit: 50,000 characters
Next steps:
- Consider breaking this PR into smaller, more focused changes if possible.
- For manual review, please reach out to your team members or maintainers.
We appreciate your understanding and commitment to improving this project. Your contributions are valuable, and we want to ensure they receive the attention they deserve.
LlamaPReview is continuously evolving to better serve the community. Share your thoughts on handling large PRs in our GitHub Discussions - your feedback helps us improve and expand our capabilities.
If you have any questions or need assistance, our community and support team are here to help.
Best regards,
LlamaPReview Team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.