Open
Conversation
djmitche
reviewed
Jul 14, 2019
Contributor
djmitche
left a comment
djmitche
left a comment
There was a problem hiding this comment.
The lower-case .md is more common, if you don't mind renaming. This looks good to me otherwise but I'm not an authoritative reviewer.
Author
|
Thanks for the tip, Dustin! I appreciate it. I added commit to local repo regarding this. Should show in PR. |
Should we request people contact LISTNAME-request@amanda.org if amanda-lists@amanda.org is more general and we already request the list name in the body of the message?
djmitche
approved these changes
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown is life.