Make declaration, definition, and use of s3/oauth2_get_access_token consistent#240
Open
tautschnig wants to merge 1 commit intozmanda:masterfrom
Open
Make declaration, definition, and use of s3/oauth2_get_access_token consistent#240tautschnig wants to merge 1 commit intozmanda:masterfrom
tautschnig wants to merge 1 commit intozmanda:masterfrom
Conversation
…onsistent The declaration promised a `gboolean`, the definition an `s3_result_t`, but its implementation would only produce a Boolean result. The use, again, mixed Booleans and `s3_result_t`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The declaration promised a
gboolean, the definition ans3_result_t, but its implementation would only produce a Boolean result. The use, again, mixed Booleans ands3_result_t.