Conversation
Otherwise, the test fails unconditionally with compilers that do not support implicit ints (a language feature that was removed with the C99 language revision).
The types char ** and const char ** are distinct according to the C language. Future compilers will treat pointer type mismatches as errors.
konidev20
approved these changes
Dec 16, 2023
There was a problem hiding this comment.
I believe this has already been reviewed as a part of #220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is #220 rebased on top of the
3_5branch. It also addresses a C compatibility issue in the CVE-2023-30547 fix.