Skip to content

Update Material 3 components to use correct theme color tokens#13

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
update-material3-theme-colors-4335559388027300314
Draft

Update Material 3 components to use correct theme color tokens#13
google-labs-jules[bot] wants to merge 1 commit intomainfrom
update-material3-theme-colors-4335559388027300314

Conversation

@google-labs-jules
Copy link
Contributor

Updated NavigationBarItem to strictly follow Material Design 3 guidelines for selected state colors, ensuring the icon/label uses OnSecondaryContainer when the indicator background is SecondaryContainer. Additionally, performed maintenance on surface/options.go to remove erroneous comments and fix imports.


PR created automatically by Jules for task 4335559388027300314 started by @zodimo

Updates `NavigationBarItem` to use `OnSecondaryContainer` for content color when selected, matching Material Design 3 specifications.
Also cleans up `compose/foundation/material3/surface/options.go` by removing malformed comments and unused imports.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants