Skip to content

Refactor TextField to use Data-Oriented/ECS Architecture#15

Draft
google-labs-jules[bot] wants to merge 1 commit intotextfieldfrom
textfield-ecs-refactor-14949712158976059466
Draft

Refactor TextField to use Data-Oriented/ECS Architecture#15
google-labs-jules[bot] wants to merge 1 commit intotextfieldfrom
textfield-ecs-refactor-14949712158976059466

Conversation

@google-labs-jules
Copy link
Contributor

Introduced a Proof-of-Concept for Data-Oriented TextField management.
This refactor moves the state management of TextFields from dispersed MutableValue objects (allocated via c.State) into a centralized TextFieldSystem.
The system maintains a dense slice of TextFieldData components, improving cache locality for state iteration and reducing GC pressure by minimizing small object allocations.
The implementation demonstrates how to separate the "Event Loop" (Input Processing) from the "Layout" phase using the System pattern, although integration into the main loop requires root-level changes.
This addresses the architectural review request to align the runtime with ECS principles.


PR created automatically by Jules for task 14949712158976059466 started by @zodimo

- Added `TextFieldSystem` to manage text field state in a flat component buffer.
- Added `TextFieldData` as an Archetype struct for text field state.
- Implemented `ECSTextField` composable demonstrating the usage of the system.
- Refactored state storage to avoid `c.State` interface boxing overhead.
- Introduced `LocalTextFieldSystem` CompositionLocal for system injection.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants