fix: return Buffer from decrypt instead of string#3
Open
elyobo wants to merge 1 commit intozoran-php:mainfrom
Open
fix: return Buffer from decrypt instead of string#3elyobo wants to merge 1 commit intozoran-php:mainfrom
elyobo wants to merge 1 commit intozoran-php:mainfrom
Conversation
Converting decrypted data to UTF-8 corrupts binary data because invalid
byte sequences are replaced with the U+FFFD replacement character. This
makes it impossible to decrypt non-text content (e.g. binary salts).
Returning a Buffer allows callers to interpret the data as needed -
they can call .toString('utf-8') for text, or use the raw bytes for
binary data.
Fixes zoran-php#2
Author
|
Note: change is straightforward but FYI was written by Claude. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converting decrypted data to UTF-8 corrupts binary data because invalid byte sequences are replaced with the U+FFFD replacement character. This makes it impossible to decrypt non-text content (e.g. binary salts used for key derivation).
This PR changes
decrypt()to return aBufferinstead of astring, allowing callers to interpret the data as needed:fernet.decrypt(token).toString('utf-8')Changes
Fernet.decrypt()now returnsBufferinstead ofstringFixes #2