Conversation
saithis
reviewed
Mar 29, 2025
projects/components/action-button/src/action-button.component.html
Outdated
Show resolved
Hide resolved
saithis
reviewed
Apr 3, 2025
projects/components/action-button/src/action-button.component.html
Outdated
Show resolved
Hide resolved
saithis
reviewed
Apr 3, 2025
projects/components/action-button/src/action-button.component.html
Outdated
Show resolved
Hide resolved
saithis
reviewed
Apr 3, 2025
projects/components/action-button/src/action-button.component.html
Outdated
Show resolved
Hide resolved
saithis
reviewed
Apr 3, 2025
projects/components/action-button/src/action-button.component.html
Outdated
Show resolved
Hide resolved
saithis
reviewed
Apr 3, 2025
projects/components/action-button/src/action-button.component.html
Outdated
Show resolved
Hide resolved
saithis
reviewed
Apr 3, 2025
saithis
reviewed
Apr 3, 2025
saithis
reviewed
Apr 3, 2025
projects/components/action-button/src/action-button.component.ts
Outdated
Show resolved
Hide resolved
Suneeh
commented
Apr 3, 2025
projects/components/action-button/src/action-button.component.scss
Outdated
Show resolved
Hide resolved
projects/components/action-button/src/action-button.component.html
Outdated
Show resolved
Hide resolved
Suneeh
force-pushed
the
19.2.3
branch
2 times, most recently
from
681adcb to
e4f1eca
Compare
* Generic ActionDataSource: property names are now more aligned with angular resources * New ActionButtonDataSource, that adds button specific functionallity to ActionDataSource * Changed IZvActionButton input to separate inputs for icon, color and disabled * Error tooltip auto shows initially * Moved all logic of action button into data source * Improved harness method names * Adjusted demo accordingly and fixed some mistakes
Suneeh
commented
Apr 5, 2025
projects/components/action-button/src/action-button.component.html
Outdated
Show resolved
Hide resolved
projects/components/action-button/src/action-button-data-source.ts
Outdated
Show resolved
Hide resolved
projects/components/action-button/src/action-button.component.ts
Outdated
Show resolved
Hide resolved
projects/components/action-button/src/action-button.component.ts
Outdated
Show resolved
Hide resolved
projects/components/action-button/src/action-button.component.ts
Outdated
Show resolved
Hide resolved
projects/zvoove-components-demo/src/app/action-button-demo/action-button-demo.component.html
Show resolved
Hide resolved
zvo-qla
approved these changes
Apr 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.