Open
Conversation
Suneeh
reviewed
Mar 31, 2025
|
|
||
| /** Either the MatFormFieldControl or a DummyMatFormFieldControl */ | ||
| private matFormFieldControl!: MatFormFieldControl<unknown>; | ||
| private matFormFieldControl = computed<MatFormFieldControl<unknown>>(() => this._control() || this.#lazyDummyMatformFieldControl.val); |
Collaborator
There was a problem hiding this comment.
Please do not introduce new linter warnings. This should be readonly
| /** Indicates if the control is no real MatFormFieldControl */ | ||
| public emulated = false; | ||
| public get emulated() { | ||
| return this.matFormFieldControl instanceof DummyMatFormFieldControl; |
| @@ -52,16 +52,23 @@ export class DummyMatFormFieldControl implements MatFormFieldControl<string>, On | |||
|
|
|||
| public autofilled?: boolean; | |||
Collaborator
There was a problem hiding this comment.
while at it - do you mind changing the indentation on the demo ?
each first line should be less indented.
and overall both blocks should be aligned, currently the 2nd block of css is indented less o.O
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.