fix: Correct lyrics scraping from Genius#1
Merged
zweack merged 2 commits intozweack:masterfrom May 30, 2025
Merged
Conversation
zweack
approved these changes
May 30, 2025
Owner
|
@yumonjiro Thanks for the PR, all looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I’m glad I finally found active fork of vscode-spotify!!
I've noticed that the lyrics display feature wasn't working since vscode-spotify. The old code was referencing an outdated HTML element tag for fetching the lyrics
I fixed the scraping logic to use the current, correct selector.
Let me know if any further changes are needed!