Port matlab test models to Python#2898
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Jul 17, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2898 +/- ##
==========================================
- Coverage 80.28% 78.96% -1.32%
==========================================
Files 330 358 +28
Lines 22660 23007 +347
Branches 1531 1570 +39
==========================================
- Hits 18192 18167 -25
- Misses 4458 4829 +371
- Partials 10 11 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
4c82983 to
6a6b537
Compare
d30d739 to
189dfc5
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
91c6470 to
1c3846c
Compare
1c3846c to
d4eb8e2
Compare
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Jul 16, 2025
When applying the chain rule factor, avoid NaN-propagation in case of zero-multiplications. (Will allow enabling the `ExampleJakstatAdjoint.SensitivityAdjointUnusedNanOutputs` test (AMICI-dev#686) after AMICI-dev#2898.)
FFroehlich
approved these changes
Jul 16, 2025
This was referenced Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(the
jakstat_adjointexample has a slightly different spline, because the old one is not exactly reproducible with the Python-AMICI spline-handling; the rest should be re-implemented pretty accurately). Model generation code is inamici.testing.models.Closes #2822.
Closes #854.