Skip to content

Fix root functions for events with initialValue=trigger=false#2910

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_event_init_false
Jul 18, 2025
Merged

Fix root functions for events with initialValue=trigger=false#2910
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_event_init_false

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 17, 2025

@dweindl dweindl requested a review from a team as a code owner July 17, 2025 20:33
@dweindl dweindl marked this pull request as draft July 17, 2025 20:43
@dweindl dweindl force-pushed the fix_event_init_false branch 3 times, most recently from 8e44b28 to 7cf49ef Compare July 17, 2025 21:05
@dweindl dweindl self-assigned this Jul 17, 2025
Fix generation of root functions for SBML event triggers if both the trigger expression and the trigger initial value are `False`.

Fixes AMICI-dev#2908.
@dweindl dweindl force-pushed the fix_event_init_false branch from 7cf49ef to e05222f Compare July 17, 2025 21:37
@dweindl dweindl marked this pull request as ready for review July 17, 2025 22:05
@dweindl dweindl enabled auto-merge July 17, 2025 22:06
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.06%. Comparing base (167864b) to head (e05222f).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2910      +/-   ##
==========================================
- Coverage   79.62%   79.06%   -0.56%     
==========================================
  Files         358      358              
  Lines       23033    23035       +2     
  Branches     1581     1581              
==========================================
- Hits        18339    18213     -126     
- Misses       4683     4811     +128     
  Partials       11       11              
Flag Coverage Δ
cpp 74.99% <100.00%> (+0.01%) ⬆️
cpp_python 33.17% <0.00%> (-0.01%) ⬇️
petab 38.98% <0.00%> (-0.01%) ⬇️
python 73.85% <100.00%> (+0.01%) ⬆️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sbml_import.py 82.21% <100.00%> (-11.99%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl added this pull request to the merge queue Jul 18, 2025
Merged via the queue into AMICI-dev:main with commit a79b917 Jul 18, 2025
23 of 25 checks passed
@dweindl dweindl deleted the fix_event_init_false branch July 19, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect root handling for some event triggers involving False and initialValue=false

2 participants