Fix root functions for events with initialValue=trigger=false#2910
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Jul 18, 2025
Merged
Fix root functions for events with initialValue=trigger=false#2910dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
8e44b28 to
7cf49ef
Compare
Fix generation of root functions for SBML event triggers if both the trigger expression and the trigger initial value are `False`. Fixes AMICI-dev#2908.
7cf49ef to
e05222f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2910 +/- ##
==========================================
- Coverage 79.62% 79.06% -0.56%
==========================================
Files 358 358
Lines 23033 23035 +2
Branches 1581 1581
==========================================
- Hits 18339 18213 -126
- Misses 4683 4811 +128
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix generation of root functions for SBML event triggers if both the trigger expression and the trigger initial value are
False.Fixes Incorrect root handling for some event triggers involving
FalseandinitialValue=false#2908.Support for
trueas trigger