Handle state-independent, parameter-dependent event triggers without root-finding#2913
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Jul 21, 2025
Merged
Conversation
dweindl
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2913 +/- ##
==========================================
- Coverage 79.45% 78.90% -0.56%
==========================================
Files 358 362 +4
Lines 23044 23092 +48
Branches 1581 1585 +4
==========================================
- Hits 18310 18221 -89
- Misses 4723 4860 +137
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
fexplicit_roots
branch
5 times, most recently
from
3b288ea to
56d7f1f
Compare
Member
Author
|
This breaks/fixes the root-after-reinitialization error example 😢 . Any ideas for other small benchmark collection models where this error can easily be triggered? EDIT: okay, sbml-semantic-00885 could be used, but there the error is fixed by exactly the opposite of what the error message suggests 🙈 |
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Jul 20, 2025
The updated discontinuity handling in AMICI-dev#2913 will break the current root-after-reinitialization error example. Change to a new example based on an SBML test suite case. Also update an error message and clean up the notebook.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 20, 2025
The updated discontinuity handling in #2913 will break the current root-after-reinitialization error example. Change to a new example based on an SBML test suite case. Also update an error message and clean up the notebook.
dweindl
force-pushed
the
fexplicit_roots
branch
3 times, most recently
from
d587a62 to
d588b61
Compare
…root-finding Since AMICI-dev#2227, events that trigger at an explicit timepoint are handled without root-finding. Events with state-independent but parameter-dependent triggers were still handled with root-finding. With these changes, those event triggers will also be handled without root-finding. Closes AMICI-dev#2185.
FFroehlich
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #2227, events that trigger at an explicit timepoint are handled without root-finding. Events with state-independent but parameter-dependent triggers were still handled with root-finding. With these changes, those event triggers will also be handled without root-finding.
This adds
Model::fexplicit_roots(p, k)to compute parameter/constant-dependent roots and replaces the old list of parameter-independent roots.Closes #2185.