Skip to content

doc: Update simulation errors example#2914

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:doc_root_after_reinit
Jul 20, 2025
Merged

doc: Update simulation errors example#2914
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:doc_root_after_reinit

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Jul 20, 2025

The updated discontinuity handling in #2913 will break the current root-after-reinitialization error example. Change to a new example based on an SBML test suite case.

Also update an error message and clean up the notebook.

The updated discontinuity handling in AMICI-dev#2913 will break the current root-after-reinitialization error example.
Change to a new example based on an SBML test suite case.

Also update an error message and clean up the notebook.
@dweindl dweindl self-assigned this Jul 20, 2025
@dweindl dweindl marked this pull request as ready for review July 20, 2025 09:57
@dweindl dweindl requested a review from a team as a code owner July 20, 2025 09:57
@dweindl dweindl enabled auto-merge July 20, 2025 09:57
@codecov
Copy link

codecov bot commented Jul 20, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.02%. Comparing base (a79b917) to head (3bf17a0).
⚠️ Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
src/solver_cvodes.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2914      +/-   ##
==========================================
- Coverage   79.63%   79.02%   -0.62%     
==========================================
  Files         358      358              
  Lines       23037    23037              
  Branches     1581     1581              
==========================================
- Hits        18346    18205     -141     
- Misses       4680     4821     +141     
  Partials       11       11              
Flag Coverage Δ
cpp 74.95% <0.00%> (-0.05%) ⬇️
cpp_python 33.17% <0.00%> (ø)
petab 38.97% <0.00%> (ø)
python 73.81% <0.00%> (-0.05%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/solver_cvodes.cpp 71.82% <0.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl added this pull request to the merge queue Jul 20, 2025
Merged via the queue into AMICI-dev:main with commit 9ae021c Jul 20, 2025
17 of 19 checks passed
@dweindl dweindl deleted the doc_root_after_reinit branch July 20, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants