Event-handling during post-equilibration for FSA#2920
Merged
dweindl merged 2 commits intoAMICI-dev:mainfrom Jul 21, 2025
Merged
Event-handling during post-equilibration for FSA#2920dweindl merged 2 commits intoAMICI-dev:mainfrom
dweindl merged 2 commits intoAMICI-dev:mainfrom
Conversation
10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
==========================================
- Coverage 79.46% 78.98% -0.48%
==========================================
Files 362 362
Lines 23092 23106 +14
Branches 1585 1587 +2
==========================================
- Hits 18349 18250 -99
- Misses 4732 4845 +113
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
* Implement event-handling during post-equilibration for no sensitivities and FSA (AMICI-dev#2775) (ASA to be implemented separately) * Additional tests for events * Fix SBML import for parameters that are event targets and have non-time-dependent intial assignments (They previously ended up both in `x` and `w`.) * Drop unused PeriodResult.nroots (meanwhile, this is recomputed from discs)
FFroehlich
approved these changes
Jul 21, 2025
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Jul 25, 2025
Event handling during forward simulation for post-equilibration was implemented in AMICI-dev#2920. Event handling during backward simulation for post-equilibration was missing and is implemented here. Closes AMICI-dev#2775.
dweindl
added a commit
that referenced
this pull request
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xandw.)PeriodResult.nroots(meanwhile, this is recomputed fromdiscs)