Skip to content

Avoid sympification in is-None checks#2945

Merged
dweindl merged 5 commits intoAMICI-dev:mainfrom
dweindl:perf_none
Sep 19, 2025
Merged

Avoid sympification in is-None checks#2945
dweindl merged 5 commits intoAMICI-dev:mainfrom
dweindl:perf_none

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Aug 28, 2025

Don't sympify if we just need to test some expression to be (not) None. Saves some time for expensive-to-sympify expressions like big piecewise constructs for splines.

Requires #2946.

Don't sympify if we just need to test some expression to be (not) None.
Saves some time for expensive-to-sympify expressions like big piecewise constructs for splines.
@dweindl dweindl self-assigned this Aug 28, 2025
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.79%. Comparing base (1b88ab4) to head (f6b7d1d).
⚠️ Report is 134 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2945      +/-   ##
==========================================
- Coverage   79.43%   78.79%   -0.65%     
==========================================
  Files         362      362              
  Lines       23183    23183              
  Branches     1588     1588              
==========================================
- Hits        18415    18266     -149     
- Misses       4756     4905     +149     
  Partials       12       12              
Flag Coverage Δ
cpp 75.51% <100.00%> (-0.07%) ⬇️
cpp_python 32.93% <100.00%> (ø)
petab 38.49% <100.00%> (ø)
python 73.57% <100.00%> (-0.07%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/sbml_import.py 80.02% <100.00%> (-12.07%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review September 13, 2025 17:52
@dweindl dweindl requested a review from a team as a code owner September 13, 2025 17:52
@dweindl dweindl enabled auto-merge September 13, 2025 17:52
@dweindl dweindl added this pull request to the merge queue Sep 19, 2025
Merged via the queue into AMICI-dev:main with commit 729e202 Sep 19, 2025
24 of 25 checks passed
@dweindl dweindl deleted the perf_none branch September 19, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants