Skip to content

Avoid sympification in is-None checks #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 5 commits into from
Sep 19, 2025
Merged

Avoid sympification in is-None checks #2945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9490718
Avoid sympification in is-None checks
dweindl Aug 28, 2025
10e8138
Merge branch 'main' into perf_none
dweindl Aug 30, 2025
735ce82
pytest-rerunfailures!=16.0
dweindl Aug 30, 2025
d3d4ca4
Merge branch 'main' into perf_none
dweindl Sep 13, 2025
f6b7d1d
Merge branch 'main' into perf_none
dweindl Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/sdist/amici/sbml_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3066,7 +3066,7 @@ def is_assignment_rule_target(self, element: libsbml.SBase) -> bool:
boolean indicating truth of function name
"""
a = self.sbml.getAssignmentRuleByVariable(element.getId())
return a is not None and self._sympify(a) is not None
return a is not None and a.getMath() is not None

def is_rate_rule_target(self, element: libsbml.SBase) -> bool:
"""
Expand All @@ -3080,7 +3080,7 @@ def is_rate_rule_target(self, element: libsbml.SBase) -> bool:
boolean indicating truth of function name
"""
a = self.sbml.getRateRuleByVariable(element.getId())
return a is not None and self._sympify(a) is not None
return a is not None and a.getMath() is not None

def _transform_dxdt_to_concentration(
self, species_id: sp.Symbol, dxdt: sp.Expr
Expand Down
3 changes: 2 additions & 1 deletion python/sdist/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ test = [
"h5py",
"pytest",
"pytest-cov",
"pytest-rerunfailures",
# v16.0: https://github.com/pytest-dev/pytest-rerunfailures/issues/302
"pytest-rerunfailures!=16.0",
"coverage",
"shyaml",
"antimony>=2.13",
Expand Down
Loading