Skip to content

Fix handling of time in algebraic rules #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dweindl merged 1 commit into from
Aug 29, 2025
Merged

Fix handling of time in algebraic rules #2946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions python/sdist/amici/sbml_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1570,7 +1570,13 @@ def _process_rule_algebraic(self, rule: libsbml.AlgebraicRule):
# completely determined by other constructs in the model"
# find those elements:
for symbol in formula.free_symbols:
if symbol == sbml_time_symbol:
continue
sbml_var = self.sbml.getElementBySId(str(symbol))
if sbml_var is None:
raise SBMLException(
f"Algebraic rule references unexpected symbol '{symbol}'."
)
# This means that at least this entity must
# not have the attribute constant=“true”
if sbml_var.isSetConstant() and sbml_var.getConstant():
Expand Down
Loading