Fix handling of time in algebraic rules#2946
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Aug 29, 2025
Merged
Conversation
Fixes the following error:
```
> if sbml_var.isSetConstant() and sbml_var.getConstant():
^^^^^^^^^^^^^^^^^^^^^^
E AttributeError: 'NoneType' object has no attribute 'isSetConstant'
```
dweindl
force-pushed
the
fix_algebraic_time
branch
from
64b8422 to
1c30922
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2946 +/- ##
==========================================
- Coverage 79.59% 79.01% -0.58%
==========================================
Files 362 362
Lines 23175 23178 +3
Branches 1588 1588
==========================================
- Hits 18446 18314 -132
- Misses 4717 4852 +135
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
FFroehlich
approved these changes
Aug 29, 2025
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Nov 2, 2025
Fixes the following error:
```
> if sbml_var.isSetConstant() and sbml_var.getConstant():
^^^^^^^^^^^^^^^^^^^^^^
E AttributeError: 'NoneType' object has no attribute 'isSetConstant'
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following error:
(
tests/sbml/testSBMLSuite.py::test_sbml_testsuite_case[00983])