Skip to content

Better type annotations#2981

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_annot
Oct 17, 2025
Merged

Better type annotations#2981
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:fix_annot

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Oct 16, 2025

  • Use unquoted types in type annotations. Fix some incorrect annotations.
  • Replace ast.Str, removed in Python 3.14

Use unqouted types in type annotations. Fix some incorrect annotations.
@dweindl dweindl self-assigned this Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.78%. Comparing base (a666ef9) to head (82df159).
⚠️ Report is 111 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/swig.py 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2981      +/-   ##
==========================================
- Coverage   76.51%   75.78%   -0.73%     
==========================================
  Files         307      307              
  Lines       19992    19997       +5     
  Branches     1500     1500              
==========================================
- Hits        15296    15154     -142     
- Misses       4683     4830     +147     
  Partials       13       13              
Flag Coverage Δ
cpp 71.95% <0.00%> (-0.06%) ⬇️
cpp_python 38.20% <0.00%> (-0.01%) ⬇️
petab 39.26% <0.00%> (-0.02%) ⬇️
python 69.52% <0.00%> (-0.05%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/swig.py 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review October 17, 2025 06:16
@dweindl dweindl requested a review from a team as a code owner October 17, 2025 06:16
@dweindl dweindl added this pull request to the merge queue Oct 17, 2025
Merged via the queue into AMICI-dev:main with commit 82f76cf Oct 17, 2025
16 of 18 checks passed
@dweindl dweindl deleted the fix_annot branch October 17, 2025 14:48
@dweindl dweindl mentioned this pull request Nov 2, 2025
dweindl added a commit to dweindl/AMICI that referenced this pull request Nov 2, 2025
Use unqouted types in type annotations. Fix some incorrect annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants