Skip to content

CI: Update libpetab, fix failing petab v2 tests#3124

Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:update_petab_testsuite
Feb 25, 2026
Merged

CI: Update libpetab, fix failing petab v2 tests#3124
dweindl merged 1 commit intoAMICI-dev:mainfrom
dweindl:update_petab_testsuite

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Feb 9, 2026

Enable previously skipped tests (https://github.com/AMICI-dev/AMICI/pull/3115/changes#r2727423334)

Skip gradient check for nx=0 models.

ruff

@dweindl dweindl self-assigned this Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.71%. Comparing base (b2699a8) to head (3beaa23).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
- Coverage   77.39%   76.71%   -0.68%     
==========================================
  Files         316      316              
  Lines       20632    20632              
  Branches     1483     1483              
==========================================
- Hits        15968    15828     -140     
- Misses       4656     4796     +140     
  Partials        8        8              
Flag Coverage Δ
cpp 70.44% <ø> (-0.03%) ⬇️
cpp_python 37.87% <ø> (ø)
petab 47.16% <ø> (ø)
python 68.90% <ø> (-0.03%) ⬇️
sbmlsuite-jax ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl force-pushed the update_petab_testsuite branch 2 times, most recently from 1f5cba9 to c0905ae Compare February 24, 2026 14:14
Enable previously skipped tests.

Skip gradient check for nx=0 models.
@dweindl dweindl force-pushed the update_petab_testsuite branch from eec0450 to 3beaa23 Compare February 24, 2026 15:09
@dweindl dweindl changed the title CI: Update petab test suite CI: Update libpetab, fix failing petab v2 tests Feb 24, 2026
@dweindl dweindl marked this pull request as ready for review February 24, 2026 15:35
@dweindl dweindl requested a review from a team as a code owner February 24, 2026 15:35
@dweindl dweindl enabled auto-merge February 24, 2026 15:35
@dweindl dweindl added this pull request to the merge queue Feb 24, 2026
Merged via the queue into AMICI-dev:main with commit 1ad4ee0 Feb 25, 2026
24 of 25 checks passed
@dweindl dweindl deleted the update_petab_testsuite branch February 25, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants