Unset loglevel in amici.sim.sundials._swig_wrappers#3150
Merged
dweindl merged 1 commit intoAMICI-dev:mainfrom Mar 4, 2026
Merged
Unset loglevel in amici.sim.sundials._swig_wrappers#3150dweindl merged 1 commit intoAMICI-dev:mainfrom
amici.sim.sundials._swig_wrappers#3150dweindl merged 1 commit intoAMICI-dev:mainfrom
Conversation
This way, that logger will inherit the log level from its parents,
and users can set the log level with, e.g.,
`logging.getLogger("amici.sim.sundials").setLevel(logging.CRITICAL)`
without exposing any private modules.
Related to AMICI-dev#3081.
`
FFroehlich
approved these changes
Mar 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3150 +/- ##
==========================================
- Coverage 77.36% 76.70% -0.66%
==========================================
Files 317 317
Lines 20628 20629 +1
Branches 1483 1484 +1
==========================================
- Hits 15958 15823 -135
- Misses 4662 4798 +136
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dweindl
added a commit
to dweindl/AMICI
that referenced
this pull request
Mar 11, 2026
Since AMICI-dev#3150, there are log messages related to changing loglevels during module imports. I think, we only want notifications for changed loglevels for pre-existing loggers. When we are changing the loglevel from debug to something higher, we don't want to see yet another debug message. Therefore, log after applying the new loglevel.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
Since #3150, there are log messages related to changing loglevels during module imports. I think, we only want notifications for changed loglevels for pre-existing loggers. When we are changing the loglevel from debug to something higher, we don't want to see yet another debug message. Therefore, log after applying the new loglevel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, that logger will inherit the log level from its parents, and users can set the log level with, e.g.,
logging.getLogger("amici.sim.sundials").setLevel(logging.CRITICAL)without exposing any private modules.Related to #3081.
`