Created a Scene page when holding the Scene button#460
Open
ArthurGibert wants to merge 1 commit intomainfrom
Open
Created a Scene page when holding the Scene button#460ArthurGibert wants to merge 1 commit intomainfrom
ArthurGibert wants to merge 1 commit intomainfrom
Conversation
feat(led): display scales as a keyboard fix(led): improve visual feedback when holding scene - display last scene - display tempo - display quantizer colors
chmanie
reviewed
Mar 4, 2026
Member
There was a problem hiding this comment.
In #459 I added a new file: https://github.com/ATOVproject/faderpunk/pull/459/changes#diff-5f52040753f2894d83c63329137f0bd1b7ccd59613bf5ad1355ef29f7566f624
Let's do all of these visual feedback things over there once it's merged
chmanie
reviewed
Mar 4, 2026
| spawner.spawn(global_config_change()).unwrap(); | ||
| } | ||
|
|
||
| pub async fn show_scale_keyboard(key: Key, tonic: Note) { |
Member
There was a problem hiding this comment.
We can also move these to the new file
chmanie
reviewed
Mar 4, 2026
| use ws2812_async::{Grb, Ws2812}; | ||
|
|
||
| use crate::tasks::buttons::{is_scene_button_pressed, LAST_SCENE_INDEX, NO_SCENE_INDEX}; | ||
| use crate::tasks::clock::{ClockEvent, CLOCK_PUBSUB}; |
Member
There was a problem hiding this comment.
I'm not a big fan of coupling the clock with the LEDs so tightly. Honestly I would probably not do any of the changes here. This really seems unnecessarily complicated. Maybe I'll take a stab at the clock LED.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scene button now flashed to the tempo
When holding the Scene button:
the last recalled scene is displayed
The tempo is displayed on fader 15 top LED
The scale and tonic color are displayed on the top fader LEDs
The scale is represented as a musical keyboard on channels 3-14 bottom LEDs (Dimmed out of scale, highlighted in the scale)