Update cell type notebook for Bioconductor 3.22#906
Merged
sjspielman merged 7 commits intomasterfrom Feb 12, 2026
Merged
Conversation
Member
Author
|
This GHA failed at an earlier notebook that I did not previously have any issues running in the Docker image: https://github.com/AlexsLemonade/training-modules/actions/runs/21910222166/job/63261677007?pr=906#step:6:25 Will investigate and try to address (possibly separate PR) before marking this ready for review. |
This was referenced Feb 11, 2026
Member
Author
|
This is now hitting an error at the AUCell notebook, which actually doesn't surprise me. But, we are past the bug that originally caused the GHA here to fail! Because of this, I'm going to put this PR on pause and tackle #898 first, which will circumvent the error here because we're switching away from genesetcollections -> lists of marker genes. |
…rough disk-space wise
Member
Author
|
Looks like we've got enough space for now at least! re-#912 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #897
This PR updates the cell type notebook for some updated SingleR behavior.
It has a new argument
test.geneswhich needs to be provided if the genes in the reference and query are not the same in the same order. Therestrictargument controls which genes are included in the DE, and isn't needed now that we have to supplytest.genes. From the current version's docs:I also made some recreational spacing updates while I was here.
Kind of annoyingly, this update doesn't appear to be reflected in rdrr which we link in the cheatsheet, but it is in the current version of the singler book.
Here is a rendered version of this updated notebook: 06-celltype_annotation.nb.html
For comparison, here is the rendered notebook at bioconductor 3.19; results are consistent! https://alexslemonade.github.io/2025-march-training/completed-notebooks/scRNA-seq/06-celltype_annotation.nb.html