Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
The test and integration smoke test expect .env.example at
src/{{ toolkit_name }}/.env.example, not at the package root.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The PR's goal is to make find_env_file() discover .env at higher directory levels. Move the scaffold template's .env.example to the package root (next to pyproject.toml) and update tests accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Addresses review concern about unbounded upward traversal finding unrelated .env files (e.g. ~/.env or C:\.env) and loading their secrets into memory or uploading them to Arcade Engine. find_env_file() now defaults to stopping at the nearest ancestor directory containing pyproject.toml. If no pyproject.toml is found, falls back to traversing to the filesystem root. An explicit stop_at parameter still overrides this behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@nbarbettini I've addressed your comment.
This prevents accidentally loading an unrelated |
arcade-mcp-server: 1.17.3 -> 1.17.4 (added _find_project_root, bounded find_env_file) arcade-mcp: 1.11.1 -> 1.11.2 Update minimum arcade-mcp-server dep across examples and root pyproject.toml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable autofix in the Cursor dashboard.
Resolves TOO-201
Documentation PR for this is here: ArcadeAI/docs#626
Note
Medium Risk
Changes how environment variables/secrets are discovered and loaded, which can subtly alter runtime behavior depending on directory structure and existing env vars; bounded traversal and added tests reduce but don’t eliminate this risk.
Overview
Improves
.envdiscovery across the MCP server and CLI. Addsfind_env_file()(bounded by the nearestpyproject.tomlby default) and switches settings loading,arcade deploy,arcade configurestdio env injection, and provider API-key resolution to use it.Updates dev reload to also watch the discovered
.enveven when it lives outside the current working directory, adjustsdeploy --secrets allto only run when a.envwas found, and moves the minimal scaffold’s.env.exampleto the project root with updated tests/integration checks. Version bumps align examples and top-level deps witharcade-mcp-server1.17.4andarcade-mcp1.11.2.Written by Cursor Bugbot for commit 40cff17. This will update automatically on new commits. Configure here.