Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
EricGustin
requested review from
a team and
torresmateo
and removed request for
torresmateo
Contributor
|
@ArcadeAI/engineering can someone stamp this? |
evantahler
approved these changes
Feb 3, 2026
Contributor
evantahler
left a comment
evantahler
left a comment
There was a problem hiding this comment.
@EricGustin approved assuming this is still valid!
Member
Author
|
It's still valid, but I need to get back around to addressing a comment on the code PR. Changing this to DRAFT for now |
EricGustin
added a commit
to ArcadeAI/arcade-mcp
that referenced
this pull request
Feb 26, 2026
Resolves TOO-201 Documentation PR for this is here: ArcadeAI/docs#626 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes how environment variables/secrets are discovered and loaded, which can subtly alter runtime behavior depending on directory structure and existing env vars; bounded traversal and added tests reduce but don’t eliminate this risk. > > **Overview** > **Improves `.env` discovery across the MCP server and CLI.** Adds `find_env_file()` (bounded by the nearest `pyproject.toml` by default) and switches settings loading, `arcade deploy`, `arcade configure` stdio env injection, and provider API-key resolution to use it. > > Updates dev reload to also watch the discovered `.env` even when it lives outside the current working directory, adjusts `deploy --secrets all` to only run when a `.env` was found, and moves the minimal scaffold’s `.env.example` to the project root with updated tests/integration checks. Version bumps align examples and top-level deps with `arcade-mcp-server` `1.17.4` and `arcade-mcp` `1.11.2`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 40cff17. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -206,7 +206,7 @@ When your tool is executed, it will return: `"Got SECRET_KEY of length..."`. In | |||
| ## Key Concepts | |||
|
|
|||
| - **Secure Access:** Secrets are accessed through context, not imported directly | |||
Contributor
There was a problem hiding this comment.
Google.Passive: Changed passive voice 'are accessed' to active voice 'access'
Suggested change
| - **Secure Access:** Secrets are accessed through context, not imported directly | |
| - **Secure Access:** Secrets access through context, not imported directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for ArcadeAI/arcade-mcp#737
Note
Low Risk
Documentation-only changes that adjust recommended
.envfile placement and wording; no runtime or API behavior is modified.Overview
Updates the MCP server quickstart and tool guides to document Arcade’s upward
.envdiscovery, changing instructions to place.env/.env.exampleat the project root and adjusting example commands accordingly (including themvpath when working fromsrc/my_server/).Aligns deployment docs to say Arcade Deploy searches for a
.envfile (not just the current directory), fixes minor formatting around.env, and refreshes the generated public markdown copies (includingLast updateddates).Written by Cursor Bugbot for commit 9ac8846. This will update automatically on new commits. Configure here.