test: add explicit mock_ask_confirmation call assertions to reset workflow tests#1350
Merged
amilcarlucas merged 2 commits intoSID_AXISfrom Mar 4, 2026
Merged
test: add explicit mock_ask_confirmation call assertions to reset workflow tests#1350amilcarlucas merged 2 commits intoSID_AXISfrom
amilcarlucas merged 2 commits intoSID_AXISfrom
Conversation
Co-authored-by: amilcarlucas <24453563+amilcarlucas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix FC reset behavior in parameter editor refactor
test: add explicit mock_ask_confirmation call assertions to reset workflow tests
Mar 4, 2026
amilcarlucas
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for
upload_parameters_that_require_reset_workflowset upmock_ask_confirmationbut never asserted whether it was invoked, leaving the confirmation callback behavior untested and vulnerable to silent regressions.Changes
SID_AXIS0→non-zero, absent→non-zero): addedmock_ask_confirmation.assert_called_once()— these paths hitreset_unsure_paramsand must prompt the userSID_AXISnon-zero→non-zero, non-zero→zero): addedmock_ask_confirmation.assert_not_called()— no reset path is entered, dialog must not appearValueError): addedmock_ask_confirmation.assert_not_called()— exception is caught before any reset logic, dialog must not appear💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.