Skip to content

test: add explicit mock_ask_confirmation call assertions to reset workflow tests #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amilcarlucas merged 2 commits into from
Mar 4, 2026
+5 −0
Merged

test: add explicit mock_ask_confirmation call assertions to reset workflow tests #1350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f266932
Initial plan
Copilot Mar 4, 2026
f7eefc1
test: add mock_ask_confirmation assertions to reset workflow tests
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/test_data_model_parameter_editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ def test_user_handles_parameter_upload_errors_gracefully(self, parameter_editor)
# Assert: Errors handled via callback
assert reset_required is False # No successful uploads
assert len(uploaded_params) == 0 # No parameters were uploaded
mock_ask_confirmation.assert_not_called()
mock_show_error.assert_called_once()
error_call_args = mock_show_error.call_args[0]
assert "Failed to set parameter" in error_call_args[1] # Second argument is the error message
Expand Down Expand Up @@ -631,6 +632,7 @@ def test_user_uploads_sid_axis_from_zero_to_nonzero_triggers_possible_reset(self
# Assert: Possible reset triggered and parameter uploaded
assert reset_happened is True
assert "SID_AXIS" in uploaded_params
mock_ask_confirmation.assert_called_once()
mock_show_error.assert_not_called()

def test_user_uploads_sid_axis_from_nonzero_to_different_nonzero_skips_reset(self, parameter_editor) -> None:
Expand Down Expand Up @@ -659,6 +661,7 @@ def test_user_uploads_sid_axis_from_nonzero_to_different_nonzero_skips_reset(sel
# to the normal upload path (not handled by this workflow)
assert reset_happened is False
assert "SID_AXIS" not in uploaded_params
mock_ask_confirmation.assert_not_called()
mock_show_error.assert_not_called()

def test_user_uploads_sid_axis_from_nonzero_to_zero_skips_reset(self, parameter_editor) -> None:
Expand Down Expand Up @@ -686,6 +689,7 @@ def test_user_uploads_sid_axis_from_nonzero_to_zero_skips_reset(self, parameter_
# Assert: No reset triggered
assert reset_happened is False
assert "SID_AXIS" not in uploaded_params
mock_ask_confirmation.assert_not_called()
mock_show_error.assert_not_called()

def test_user_uploads_sid_axis_absent_from_fc_to_nonzero_triggers_possible_reset(self, parameter_editor) -> None:
Expand Down Expand Up @@ -713,6 +717,7 @@ def test_user_uploads_sid_axis_absent_from_fc_to_nonzero_triggers_possible_reset
# Assert: Possible reset triggered and parameter uploaded
assert reset_happened is True
assert "SID_AXIS" in uploaded_params
mock_ask_confirmation.assert_called_once()
mock_show_error.assert_not_called()


Expand Down
Loading