Add practical PHP testing guidance to AGENTS.md#47618
Open
Conversation
Expand the PHP Testing section with details that AI agents need to correctly run and write tests: verbose/filter flags, WorDBless patterns, and the jp test vs jp docker distinction for plugins/jetpack.
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes
While working on the
packages/connectionpackage, an AI coding agent couldn't figure out how to run the package's PHP tests. It guessed commands likejp phpunit(which doesn't exist) and failed to discover the correctjp test phpinvocation with its flags. The existing AGENTS.md Testing section listed the basic commands but lacked the practical details agents need to actually run and write tests.This expands the PHP Testing section with:
jp test phpworks for all projects exceptplugins/jetpack(which usesjp dockercommands)--verboseand--filterflag usage with concrete examplesWorDBless\BaseTestCase, usewp_insert_user()+get_userdata()instead ofself::factory()->user->create_and_get()(which is not available in WorDBless)projects/packages/connection/tests/php/sso/Helpers_Test.phpOther information
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
AGENTS.mdfor accuracy and completeness.