-
Notifications
You must be signed in to change notification settings - Fork 1
New Crowdin updates #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Crowdin updates #70
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates translation files to reflect a change in the "Permit a token" hook description from "Infinite permit..." to simply "Permit...". The revision dates are updated to November 3, 2025.
- Changed the descriptive text for the permit hook from "Infinite permit..." to "Permit..."
- Marked obsolete translation entries appropriately across locale files
- Updated revision dates in translation metadata
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/cowswap-frontend/src/locales/ru-RU.po | Updated Russian translation file to add new permit message and mark old "Infinite permit" entry as obsolete |
| apps/cowswap-frontend/src/locales/es-ES.po | Updated Spanish translation file to add new permit message and mark old "Infinite permit" entry as obsolete |
| apps/cowswap-frontend/src/locales/en-US.po | Reverted obsolete "Infinite permit" entry back to active state while removing the new "Permit" entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| msgid "Infinite permit an address to spend one token on your behalf." | ||
| msgstr "Infinite permit an address to spend one token on your behalf." |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The en-US.po file reverts the translation change, making it inconsistent with the source code. According to hookDappsRegistry.ts line 33, the current text is 'Permit an address to spend one token on your behalf.' (without 'Infinite'). The en-US.po file should mark the 'Infinite permit...' entry as obsolete and add the new 'Permit...' entry, matching the pattern in ru-RU.po and es-ES.po.
| msgid "Infinite permit an address to spend one token on your behalf." | ||
| msgstr "Бесконечное разрешение на использование одного токена от вашего имени." | ||
| #~ msgid "Infinite permit an address to spend one token on your behalf." | ||
| #~ msgstr "Infinite permit an address to spend one token on your behalf." |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The obsolete translation entry should retain the original Russian translation 'Бесконечное разрешение на использование одного токена от вашего имени.' instead of replacing it with the English text. This loses the previously translated Russian text.
| #~ msgstr "Infinite permit an address to spend one token on your behalf." | |
| #~ msgstr "Бесконечное разрешение на использование одного токена от вашего имени." |
| msgid "Infinite permit an address to spend one token on your behalf." | ||
| msgstr "Permita infinito que una dirección gaste un token en su nombre." | ||
| #~ msgid "Infinite permit an address to spend one token on your behalf." | ||
| #~ msgstr "Infinite permit an address to spend one token on your behalf." |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The obsolete translation entry should retain the original Spanish translation 'Permita infinito que una dirección gaste un token en su nombre.' instead of replacing it with the English text. This loses the previously translated Spanish text.
| #~ msgstr "Infinite permit an address to spend one token on your behalf." | |
| #~ msgstr "Permita infinito que una dirección gaste un token en su nombre." |
c78dd1b
into
feat/internationalization-setup-for-swap-cow-fi
No description provided.