Skip to content

Conversation

@gabitoesmiapodo
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cowswap Ready Ready Preview Comment Nov 3, 2025 2:07pm

@github-actions
Copy link

github-actions bot commented Nov 3, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates translation files to reflect a change in the "Permit a token" hook description from "Infinite permit..." to simply "Permit...". The revision dates are updated to November 3, 2025.

  • Changed the descriptive text for the permit hook from "Infinite permit..." to "Permit..."
  • Marked obsolete translation entries appropriately across locale files
  • Updated revision dates in translation metadata

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
apps/cowswap-frontend/src/locales/ru-RU.po Updated Russian translation file to add new permit message and mark old "Infinite permit" entry as obsolete
apps/cowswap-frontend/src/locales/es-ES.po Updated Spanish translation file to add new permit message and mark old "Infinite permit" entry as obsolete
apps/cowswap-frontend/src/locales/en-US.po Reverted obsolete "Infinite permit" entry back to active state while removing the new "Permit" entry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 524 to 525
msgid "Infinite permit an address to spend one token on your behalf."
msgstr "Infinite permit an address to spend one token on your behalf."
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The en-US.po file reverts the translation change, making it inconsistent with the source code. According to hookDappsRegistry.ts line 33, the current text is 'Permit an address to spend one token on your behalf.' (without 'Infinite'). The en-US.po file should mark the 'Infinite permit...' entry as obsolete and add the new 'Permit...' entry, matching the pattern in ru-RU.po and es-ES.po.

Copilot uses AI. Check for mistakes.
msgid "Infinite permit an address to spend one token on your behalf."
msgstr "Бесконечное разрешение на использование одного токена от вашего имени."
#~ msgid "Infinite permit an address to spend one token on your behalf."
#~ msgstr "Infinite permit an address to spend one token on your behalf."
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation entry should retain the original Russian translation 'Бесконечное разрешение на использование одного токена от вашего имени.' instead of replacing it with the English text. This loses the previously translated Russian text.

Suggested change
#~ msgstr "Infinite permit an address to spend one token on your behalf."
#~ msgstr "Бесконечное разрешение на использование одного токена от вашего имени."

Copilot uses AI. Check for mistakes.
msgid "Infinite permit an address to spend one token on your behalf."
msgstr "Permita infinito que una dirección gaste un token en su nombre."
#~ msgid "Infinite permit an address to spend one token on your behalf."
#~ msgstr "Infinite permit an address to spend one token on your behalf."
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The obsolete translation entry should retain the original Spanish translation 'Permita infinito que una dirección gaste un token en su nombre.' instead of replacing it with the English text. This loses the previously translated Spanish text.

Suggested change
#~ msgstr "Infinite permit an address to spend one token on your behalf."
#~ msgstr "Permita infinito que una dirección gaste un token en su nombre."

Copilot uses AI. Check for mistakes.
@gabitoesmiapodo gabitoesmiapodo merged commit c78dd1b into feat/internationalization-setup-for-swap-cow-fi Nov 3, 2025
2 of 5 checks passed
@gabitoesmiapodo gabitoesmiapodo deleted the l10n_feat/internationalization-setup-for-swap-cow-fi branch November 3, 2025 14:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants