Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds cleanup of existing FIFOs before creating new ones in RunnerFifo::new() to prevent potential hangs caused by pre-existing FIFO files.
- Added explicit unlink calls for both
RUNNER_CTL_FIFOandRUNNER_ACK_FIFObefore creating them
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+36
to
+37
| let _ = nix::unistd::unlink(RUNNER_CTL_FIFO); | ||
| let _ = nix::unistd::unlink(RUNNER_ACK_FIFO); |
There was a problem hiding this comment.
These unlink calls are redundant. The create_fifo function already unlinks any existing FIFO on line 12 before creating a new one. Consider removing lines 35-37 to avoid code duplication.
Suggested change
| let _ = nix::unistd::unlink(RUNNER_CTL_FIFO); | |
| let _ = nix::unistd::unlink(RUNNER_ACK_FIFO); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.