Skip to content

fix: cleanup fifo before creating#146

Closed
not-matthias wants to merge 1 commit intomainfrom
cod-1257-cleanup-fifo-from-previous-run-in-instrument-hooks
Closed

fix: cleanup fifo before creating#146
not-matthias wants to merge 1 commit intomainfrom
cod-1257-cleanup-fifo-from-previous-run-in-instrument-hooks

Conversation

@not-matthias
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds cleanup of existing FIFOs before creating new ones in RunnerFifo::new() to prevent potential hangs caused by pre-existing FIFO files.

  • Added explicit unlink calls for both RUNNER_CTL_FIFO and RUNNER_ACK_FIFO before creating them

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +36 to +37
let _ = nix::unistd::unlink(RUNNER_CTL_FIFO);
let _ = nix::unistd::unlink(RUNNER_ACK_FIFO);
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These unlink calls are redundant. The create_fifo function already unlinks any existing FIFO on line 12 before creating a new one. Consider removing lines 35-37 to avoid code duplication.

Suggested change
let _ = nix::unistd::unlink(RUNNER_CTL_FIFO);
let _ = nix::unistd::unlink(RUNNER_ACK_FIFO);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments