Skip to content

fix: cleanup fifo before creating #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
not-matthias wants to merge 1 commit into from
Closed

fix: cleanup fifo before creating #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/run/runner/wall_time/perf/fifo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ fn get_pipe_open_options() -> TokioPipeOpenOptions {

impl RunnerFifo {
pub fn new() -> anyhow::Result<Self> {
// Delete any existing FIFOs to avoid hangs
let _ = nix::unistd::unlink(RUNNER_CTL_FIFO);
let _ = nix::unistd::unlink(RUNNER_ACK_FIFO);
Comment on lines +36 to +37
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These unlink calls are redundant. The create_fifo function already unlinks any existing FIFO on line 12 before creating a new one. Consider removing lines 35-37 to avoid code duplication.

Suggested change
let _ = nix::unistd::unlink(RUNNER_CTL_FIFO);
let _ = nix::unistd::unlink(RUNNER_ACK_FIFO);

Copilot uses AI. Check for mistakes.

create_fifo(RUNNER_CTL_FIFO)?;
create_fifo(RUNNER_ACK_FIFO)?;

Expand Down
Loading