[CDX-23] Fix errors thrown out by test:types#397
Conversation
| @@ -0,0 +1,29 @@ | |||
| import { EventEmitter } from './events'; | |||
|
|
|||
| export default class RequestQueue { | |||
There was a problem hiding this comment.
@Mudaafi do you think we should type this in detail or is it enough for purposes of this story?
There was a problem hiding this comment.
My 2cents - I think this is probably fine as we probably won't expect folks to make changes to this often, and consumers of the library wouldn't be expected to use it directly. It'd be helpful for future devs that work within the repo, but we can always add more details in the future if needed.
The decision is ultimately up to you guys though. 👍
jjl014
left a comment
jjl014
left a comment
There was a problem hiding this comment.
The changes look good to me! 🚀
| @@ -0,0 +1,29 @@ | |||
| import { EventEmitter } from './events'; | |||
|
|
|||
| export default class RequestQueue { | |||
There was a problem hiding this comment.
My 2cents - I think this is probably fine as we probably won't expect folks to make changes to this often, and consumers of the library wouldn't be expected to use it directly. It'd be helpful for future devs that work within the repo, but we can always add more details in the future if needed.
The decision is ultimately up to you guys though. 👍
2 participants
No description provided.