Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/types/events.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// Source: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/events/index.d.ts

export type Listener = (...args: any[]) => void;

export class EventEmitter {
static listenerCount(emitter: EventEmitter, type: string | number): number;

static defaultMaxListeners: number;

eventNames(): Array<string | number>;

setMaxListeners(n: number): this;

getMaxListeners(): number;

emit(type: string | number, ...args: any[]): boolean;

addListener(type: string | number, listener: Listener): this;

on(type: string | number, listener: Listener): this;

once(type: string | number, listener: Listener): this;

prependListener(type: string | number, listener: Listener): this;

prependOnceListener(type: string | number, listener: Listener): this;

removeListener(type: string | number, listener: Listener): this;

off(type: string | number, listener: Listener): this;

removeAllListeners(type?: string | number): this;

listeners(type: string | number): Listener[];

listenerCount(type: string | number): number;

rawListeners(type: string | number): Listener[];
}
1 change: 0 additions & 1 deletion src/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export * from './recommendations';
export * from './browse';
export * from './tracker';
export * from './event-dispatcher';
export * from './constructorio';

export interface NetworkParameters extends Record<string, any> {
timeout?: number;
Expand Down
29 changes: 29 additions & 0 deletions src/types/request-queue.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { EventEmitter } from './events';

export default class RequestQueue {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mudaafi do you think we should type this in detail or is it enough for purposes of this story?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2cents - I think this is probably fine as we probably won't expect folks to make changes to this often, and consumers of the library wouldn't be expected to use it directly. It'd be helpful for future devs that work within the repo, but we can always add more details in the future if needed.

The decision is ultimately up to you guys though. 👍

constructor(options: any, eventemitter: EventEmitter);

options: any;

eventemitter: EventEmitter;

humanity: any;

requestPending: boolean;

pageUnloading: boolean;

sendTrackingEvents: boolean;

queue(url: string, method?: string, body?: any, networkParameters?: any): void;

sendEvents(): void;

send(): void;

static get(): any[];

static set(queue: any[]): void;

static remove(): void;
}
6 changes: 3 additions & 3 deletions src/types/tracker.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import EventEmitter = require('events');
import { EventEmitter } from './events';
import { ConstructorClientOptions, ItemTracked, ItemTrackedPurchase, Question, TimeSpan, NetworkParameters } from '.';
import RequestQueue = require('../utils/request-queue');
import RequestQueue from './request-queue';

export default Tracker;

Expand Down Expand Up @@ -109,7 +109,7 @@ declare class Tracker {

trackConversion(
term?: string,
parameters: {
parameters?: {
itemId: string;
revenue?: number;
itemName?: string;
Expand Down
Loading