At the moment the Overview pages are not multi language compatible.#121
Open
leonhelmus wants to merge 1 commit intoEmicoEcommerce:masterfrom
Open
Conversation
By moving the columns overview_page_id / overview_page_image we can define this on store level which allows multi store language support.
Collaborator
|
@leonhelmus So instead of making the overview pages itself multi language. This pull requests makes it possible to make multiple overview pages and select an different overview page per storeview for an landingpage. Do i understand it correctly? I'll discuss this internally to see if this is the solution we want, or if we want to make the overview pages itself multi language. |
Author
|
@AH-NET the other solution would also be nice, but this one costed me the lowest effort. And yes you are understanding me correctly 😁 |
Collaborator
|
@leonhelmus We would prefer the another solution which makes the overview pages itself multilanguage. We've added this to our backlog. But feel free to make an pull request of this if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By moving the columns overview_page_id / overview_page_image we can define this on store level which allows multi store language support.