Skip to content

Dev.ej/more refactor#775

Open
joanise wants to merge 8 commits intodev.ej/refactor-stufffrom
dev.ej/more-refactor
Open

Dev.ej/more refactor#775
joanise wants to merge 8 commits intodev.ej/refactor-stufffrom
dev.ej/more-refactor

Conversation

@joanise
Copy link
Member

@joanise joanise commented Mar 11, 2026

PR Goal?

More systematic refactoring of how we use Typer.

Feedback sought?

sanity check

Confidence?

high

Version change?

no

Related PRs?

#771
EveryVoiceTTS/FastSpeech2_lightning#132
EveryVoiceTTS/HiFiGAN_iSTFT_lightning#58

@semanticdiff-com
Copy link

semanticdiff-com bot commented Mar 11, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/config/text_config.py  100% smaller
  everyvoice/wizard/dataset.py  96% smaller
  everyvoice/tests/regression/subsample.py  83% smaller
  everyvoice/base_cli/checkpoint.py  59% smaller
  everyvoice/base_cli/interfaces.py  39% smaller
  everyvoice/cli.py  20% smaller
  everyvoice/model/feature_prediction/FastSpeech2_lightning  0% smaller
  everyvoice/model/vocoder/HiFiGAN_iSTFT_lightning  0% smaller

@joanise joanise requested a review from SamuelLarkin March 11, 2026 15:08
@joanise joanise changed the base branch from main to dev.ej/refactor-stuff March 11, 2026 15:09
@github-actions
Copy link
Contributor

CLI load time: 0:00.32
Pull Request HEAD: e8334f55f1fd1a5326465aae45e254919db0fdc6
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:     11013 |     168593 | everyvoice.cli

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.79%. Comparing base (e395a97) to head (e8334f5).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           dev.ej/refactor-stuff     #775      +/-   ##
=========================================================
+ Coverage                  82.76%   82.79%   +0.03%     
=========================================================
  Files                         47       47              
  Lines                       4119     4127       +8     
  Branches                     607      607              
=========================================================
+ Hits                        3409     3417       +8     
  Misses                       579      579              
  Partials                     131      131              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant