Skip to content

Dev.ej/more refactor#132

Open
joanise wants to merge 3 commits intomainfrom
dev.ej/more-refactor
Open

Dev.ej/more refactor#132
joanise wants to merge 3 commits intomainfrom
dev.ej/more-refactor

Conversation

@joanise
Copy link
Member

@joanise joanise commented Mar 11, 2026

typer documentation now says to prefer Annotated over typer.Option and
typer.Argument with a default value. This commit applies that recommendation
in a lot of instances.
@joanise joanise requested a review from SamuelLarkin March 11, 2026 15:10
@semanticdiff-com
Copy link

semanticdiff-com bot commented Mar 11, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  fs2/config/__init__.py  100% smaller
  fs2/cli/check_data.py  37% smaller
  fs2/cli/benchmark.py  33% smaller
  fs2/cli/synthesize.py  30% smaller

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.64%. Comparing base (2d532db) to head (c5c8991).

Files with missing lines Patch % Lines
fs2/cli/check_data.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   49.64%   49.64%           
=======================================
  Files          27       27           
  Lines        1984     1986    +2     
=======================================
+ Hits          985      986    +1     
- Misses        999     1000    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant