Open
Conversation
ilang-flytrex
commented
Feb 17, 2026
ilang-flytrex
commented
- Add 21000.TCAData.uavcan
There was a problem hiding this comment.
Pull request overview
Adds a new Flytrex diagnostics DroneCAN/UAVCAN DSDL message definition intended to carry TCA/BMS diagnostic data for end-of-line testing.
Changes:
- Introduce new
21000.TCAData.uavcanmessage underflytrex/diagnostics/bms/. - Define fields for DUT raw voltages/counter/scales and several boolean status indicators.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
grisharevzin
requested changes
Feb 17, 2026
|
|
||
| int32 dut_vbat_raw # Device under test VBAT | ||
| int32 dut_vchg_raw # Device under test VCHG | ||
| uint32 dut_cut_raw # Device under test CUT |
There was a problem hiding this comment.
Let's keep this one int32 as well, also it's supposed to be dut_cur_raw instead of 'cut'.
| @@ -0,0 +1,11 @@ | |||
| # Propulsion Controller: Diagnostic Open Loop Data for automated end-of-line testing | |||
There was a problem hiding this comment.
Looks like it's not the right comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.