Develop #548
Merged
Develop #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR optimizes component rendering with memoization (useCallback, React.memo), centralizes menu fetching via a new React Query hook (useStoreMenus), and refactors OrderListPage by extracting logic into a custom hook (useOrderListLogic) and presentational components. It includes minor prop renames (id → menuId), type improvements, and path corrections across both admin and user-facing apps. Changes
Sequence Diagram(s)sequenceDiagram
participant OLP as OrderListPage
participant UOL as useOrderListLogic
participant CartStore as CartStore
participant RQ as React Query
participant API as API
participant Modal as SoldOutModal
participant Nav as Navigation
OLP->>UOL: initialize hook
UOL->>CartStore: getCart()
CartStore-->>UOL: cart array
rect rgb(200, 220, 255)
Note over UOL,API: Menu Fetching Phase
UOL->>RQ: useStoreMenuList(storeId)
RQ->>API: getStoreMenus(storeId)
API-->>RQ: menu data
RQ-->>UOL: menus with menuReadDto
end
rect rgb(255, 220, 200)
Note over UOL,Modal: Sold-Out Check & Modal Flow
UOL->>UOL: getSoldOutMenusInCart(cart, menus)
alt Sold-Out Items Found
UOL->>Modal: modal.open()
OLP->>Modal: render SoldOutModal
Modal-->>OLP: user clicks confirm
OLP->>UOL: handleRemoveSoldOutMenus()
UOL->>CartStore: removeFromCart(menuIds)
UOL->>Modal: modal.close()
else No Sold-Out Items
UOL->>Nav: navigate to remittance page
end
end
OLP->>OLP: render with hook state (cart, isAnimatingOut, modal, soldOutMenus)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (18)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
문제점 및 어려움
해결 방안
공유 사항
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.