Skip to content

[REFACTOR] API 경로 수정#561

Merged
oriNuguri25 merged 2 commits intomainfrom
develop
Jan 9, 2026
Merged

[REFACTOR] API 경로 수정#561
oriNuguri25 merged 2 commits intomainfrom
develop

Conversation

@oriNuguri25
Copy link
Collaborator

@oriNuguri25 oriNuguri25 commented Jan 9, 2026

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • Refactor
    • Updated internal API integration for reservation operations to use current service endpoints.
    • Enhanced delete operation request handling.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot requested a review from dgKim1 January 9, 2026 05:06
@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

A single file in the reservation API module was updated with two internal changes: migration of the reservation creation endpoint from a legacy to standard path, and a refactored parameter passing convention for the signal parameter in the delete bookmark function.

Changes

Cohort / File(s) Summary
API Endpoint Migration
apps/nowait-user/src/api/reservation.ts
Updated createReservation to use the standard endpoint /users/me/waitings/${storeId} instead of the legacy path. Modified deleteBookmark to pass the signal parameter via a configuration object { signal } rather than as a positional argument to UserApi.delete.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

  • hwangdae
  • dgKim1

Poem

A rabbit hops through legacy halls,
Finds a shorter, cleaner path,
Signals now in config calls,
No more scattered aftermath! 🐰✨

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b40f81 and fddf88f.

📒 Files selected for processing (1)
  • apps/nowait-user/src/api/reservation.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oriNuguri25 oriNuguri25 merged commit bc085b8 into main Jan 9, 2026
2 of 3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant