Skip to content

feat: Abstract USART API #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
GabeMillikan wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

feat: Abstract USART API #55

GabeMillikan wants to merge 33 commits into from

Conversation

@GabeMillikan
Copy link
Contributor

@GabeMillikan GabeMillikan commented Oct 16, 2025 •
edited
Loading

Implements #33

@dchansen06 dchansen06 added this to the GR26 milestone Oct 19, 2025
@dchansen06 dchansen06 added the Peripheral Related to or involving a peripheral including abstractions label Oct 19, 2025
@dchansen06 dchansen06 added Enhancement New feature or request HOOTL Testing Having to do with or interacting with HOOTL testing labels Oct 21, 2025
@GabeMillikan GabeMillikan mentioned this pull request Oct 22, 2025
Merged
GabeMillikan added a commit that referenced this pull request Oct 22, 2025
@GabeMillikan
Reorganize Lib/FancyLayers (#64)
21a0b09 
decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally
GabeMillikan added a commit that referenced this pull request Oct 27, 2025
@GabeMillikan
Reorganize Lib/FancyLayers (#64)
8c5fc8a 
decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally
@dchansen06
Copy link
Contributor

dchansen06 commented Oct 29, 2025

Please consider updating branch with rebase to keep it up to date with main

@dchansen06
Copy link
Contributor

dchansen06 commented Oct 29, 2025

Implements #33

Eventually, please make sure this is updated to a real description before requesting a review. That does not have to happen right now but eventually

GabeMillikan added a commit that referenced this pull request Oct 30, 2025
@GabeMillikan
Reorganize Lib/FancyLayers (#64)
05dcfd7 
decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally
@dchansen06 dchansen06 mentioned this pull request Oct 30, 2025
Merged
dchansen06 added a commit that referenced this pull request Oct 31, 2025
@dchansen06 @github-actions
Implement LOGOMATIC at the Project Level (#80)
e2de9f4 
Resolves #68 and enables serial logging using the `LOGOMATIC` macro

Also does small clean-up of related areas

Also adds tests for the logging (`G4HELLO` and HOOTL testing)

Very similar to how [ECU-25](https://github.com/Gaucho-Racing/ECU-25)
handled logging

Once #60 or #55 or something is merged in then this may have to be
expanded to support it, but without a way to test that functionality
that bridge will be crossed then.

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
GabeMillikan added a commit that referenced this pull request Oct 31, 2025
@GabeMillikan
Reorganize Lib/FancyLayers (#64)
de6e22d 
decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally
GabeMillikan added a commit that referenced this pull request Nov 2, 2025
@GabeMillikan
Reorganize Lib/FancyLayers (#64)
d57ae11 
decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally
GabeMillikan added a commit that referenced this pull request Nov 2, 2025
@GabeMillikan
Reorganize Lib/FancyLayers (#64)
eaf829c 
decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally
GabeMillikan added a commit that referenced this pull request Nov 6, 2025
@GabeMillikan
Reorganize Lib/FancyLayers (#64)
f44734b 
decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally
GabeMillikan added a commit that referenced this pull request Nov 6, 2025
@GabeMillikan
Reorganize Lib/FancyLayers (#64)
ac8a871 
decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally
GabeMillikan added a commit that referenced this pull request Nov 6, 2025
@GabeMillikan
squash because git history is fucked 😂✌️(was: ea61956)
7e6e7d3 
undo changes to ecu code

working synchronous usart

undore more bad rebase changes

Automatic CMake Format: Standardized formatting automatically

undo bad rebase changes

Automatic CMake Format: Standardized formatting automatically

fix bad rebase changes

undo unintended changes after bad rebase

Automatic CMake Format: Standardized formatting automatically

move `include(common.cmake)` into global `/CMakeLists.txt`

move include into "user code" section

add back temp code

fix build

Automatic CMake Format: Standardized formatting automatically

start moving global cmake to project specific thing

crossplatform includes

a real implementation

better naming conventions and no more function pointers

include function pointers in the handle

fix macos compile errors

empty init/tx/rx/free functions

Automatic CMake Format: Standardized formatting automatically

cmake setup (probably bad, but working)

Reorganize Lib/FancyLayers (#64)

decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally

Automatic CMake Format: Standardized formatting automatically

move `include(common.cmake)` into global `/CMakeLists.txt`

move include into "user code" section

add back temp code

fix build

Automatic CMake Format: Standardized formatting automatically

start moving global cmake to project specific thing

crossplatform includes

a real implementation

better naming conventions and no more function pointers

include function pointers in the handle

fix macos compile errors

empty init/tx/rx/free functions

Automatic CMake Format: Standardized formatting automatically

cmake setup (probably bad, but working)

grammar in readme

Reorganize Lib/FancyLayers (#64)

decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally

add todo comment
GabeMillikan added a commit that referenced this pull request Nov 6, 2025
@GabeMillikan
squash because git history is fucked 😂✌️(was: ea61956)
0a5e90e 
undo changes to ecu code

working synchronous usart

undore more bad rebase changes

Automatic CMake Format: Standardized formatting automatically

undo bad rebase changes

Automatic CMake Format: Standardized formatting automatically

fix bad rebase changes

undo unintended changes after bad rebase

Automatic CMake Format: Standardized formatting automatically

move `include(common.cmake)` into global `/CMakeLists.txt`

move include into "user code" section

add back temp code

fix build

Automatic CMake Format: Standardized formatting automatically

start moving global cmake to project specific thing

crossplatform includes

a real implementation

better naming conventions and no more function pointers

include function pointers in the handle

fix macos compile errors

empty init/tx/rx/free functions

Automatic CMake Format: Standardized formatting automatically

cmake setup (probably bad, but working)

Reorganize Lib/FancyLayers (#64)

decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally

Automatic CMake Format: Standardized formatting automatically

move `include(common.cmake)` into global `/CMakeLists.txt`

move include into "user code" section

add back temp code

fix build

Automatic CMake Format: Standardized formatting automatically

start moving global cmake to project specific thing

crossplatform includes

a real implementation

better naming conventions and no more function pointers

include function pointers in the handle

fix macos compile errors

empty init/tx/rx/free functions

Automatic CMake Format: Standardized formatting automatically

cmake setup (probably bad, but working)

grammar in readme

Reorganize Lib/FancyLayers (#64)

decided I wanted to move these changes into #55, if it won't let me
merge this then I'll just copy the changes locally

add todo comment
@dchansen06 dchansen06 mentioned this pull request Nov 10, 2025
Merged
@dchansen06 dchansen06 marked this pull request as ready for review November 10, 2025 07:28
Base automatically changed from gabe.fix-circularBuffer-pop-nothing to main November 14, 2025 03:07
GabeMillikan
GabeMillikan commented Dec 9, 2025
View reviewed changes
@dchansen06
Fix ordering of USART release, hardware then handle
140a370 
Resolves #55 (comment)

Signed-off-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com>
@dchansen06
Merge branch 'main' into usart-initial-impl
887add5
@dchansen06 dchansen06 assigned dchansen06 and unassigned dchansen06 Dec 10, 2025
@dchansen06 dchansen06 linked an issue Dec 10, 2025 that may be closed by this pull request
USART Peripheral Abstractions #33
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchansen06 dchansen06 Awaiting requested review from dchansen06 dchansen06 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Enhancement New feature or request HOOTL Testing Having to do with or interacting with HOOTL testing Peripheral Related to or involving a peripheral including abstractions

Projects

None yet

Milestone

GR26 - Firmware Feature Freeze

Development

Successfully merging this pull request may close these issues.

USART Peripheral Abstractions

2 participants

@GabeMillikan @dchansen06