Reorder sky2pix/cel2nat for gwcs_to_wcs transform#88
Merged
Conversation
Reorders the sky2pix and cel2nat models in astrodata.wcs.gwcs_to_fits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, tests in DRAGONS were failing because of an issue with a
"sky2pix"model not being found duringgwcs_to_wcs. The issue appears to be ordering of"sky2pix"and"cel2nat"models when replacing them in the inverse transform as part ofgwcs_to_wcs.This applies what currently happens in DRAGONS, it was likely a mis-translation while I was bringing changes over.