Skip to content

Reorder sky2pix/cel2nat for gwcs_to_wcs transform #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teald merged 1 commit into from
Mar 5, 2025
Merged

Reorder sky2pix/cel2nat for gwcs_to_wcs transform #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions astrodata/wcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def gwcs_to_fits(ndd, hdr=None):
# Remove projection parts so we can calculate the CD matrix
if projcode:
nat2cel.name = "nat2cel"
transform_inverse = transform.inverse
transform_inverse = transform.inverse.copy()

for m in transform_inverse:
if isinstance(m, models.RotateCelestial2Native):
Expand All @@ -316,10 +316,10 @@ def gwcs_to_fits(ndd, hdr=None):
m.name = "sky2pix"

transform_inverse = transform_inverse.replace_submodel(
"cel2nat", models.Identity(2)
"sky2pix", models.Identity(2)
)
transform_inverse = transform_inverse.replace_submodel(
"sky2pix", models.Identity(2)
"cel2nat", models.Identity(2)
)

transform = transform.replace_submodel(
Expand Down Expand Up @@ -958,7 +958,7 @@ def fitswcs_image(header):
sky_axes, _, _ = get_axes(wcs_info)

if not sky_axes:
return None
return
# if len(unknown) == 2:
# sky_axes = unknown
# else: # No sky here
Expand Down Expand Up @@ -1056,7 +1056,7 @@ def fitswcs_other(header, other=None):
crpix = wcs_info["CRPIX"]
crval = wcs_info["CRVAL"]
# get the part of the CD matrix corresponding to the imaging axes
_, spec_axes, unknown = get_axes(wcs_info)
sky_axes, spec_axes, unknown = get_axes(wcs_info)

# if not sky_axes and len(unknown) == 2:
# unknown = []
Expand Down
Loading