Missing change to previous commit#496
Closed
MathewBensonCode wants to merge 4 commits intoJeanPhilippeKernel:user/kernel/fix-updateafter-from
Closed
Missing change to previous commit#496MathewBensonCode wants to merge 4 commits intoJeanPhilippeKernel:user/kernel/fix-updateafter-from
MathewBensonCode wants to merge 4 commits intoJeanPhilippeKernel:user/kernel/fix-updateafter-from
Conversation
- The code that relies on the SwapchainImageCount such as the command buffer are re-arranged to ensure that they run after we establish the correct number of Swapchain Images
- Removed Redundant parameter to the CommandBufferManager.Initialize method - Moved the EnquedCommandBuffers.init method to be called right after the m_buffer_manager.Initialize function call
MathewBensonCode
changed the base branch from
develop
to
user/kernel/fix-updateafter-
Owner
|
ha - I already fixed it in the PR with other bunch of edges cases - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed out the header in the final commit to #495.
This is actually related to #485 as I generally have to keep reverting the changes made to the
VulkanHeader.handCoroutineScheduler.hfiles due to the formatting in the main script.The changes in #485 are beneficial on any developer machine with the newer llvm versions as we put the
clang-formatguard on the problematic lines.