Skip to content

Missing change to previous commit #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MathewBensonCode wants to merge 4 commits into from
Closed

Missing change to previous commit #496

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1660e12
Re-Arrange Code flow after swapchainimage count change
MathewBenson Jan 27, 2026
f45be5c
Pull Request #495 Requested Changes
MathewBenson Jan 28, 2026
ee312db
Add VulkanDevice.h change left out of previous commit
MathewBenson Jan 29, 2026
d737e54
Merge branch 'user/kernel/fix-updateafter-' into afterbind
MathewBensonCode Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ZEngine/ZEngine/Hardwares/VulkanDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ namespace ZEngine::Hardwares

struct CommandBufferManager
{
void Initialize(VulkanDevice* device, uint8_t swapchain_image_count = 3, int thread_count = 1);
void Initialize(VulkanDevice* device, int thread_count = 1);
void Deinitialize();
CommandBuffer* GetCommandBuffer(uint8_t frame_index, bool begin = true);
CommandBuffer* GetInstantCommandBuffer(Rendering::QueueType type, uint8_t frame_index, bool begin = true);
Expand Down