AHDC: apply ADC gain calibration from /calibration/alert/ahdc/gains

[cpaudel]

applied AHDC gain calibration to the Hit bank, updated CalibrationConstantLoader, built and ran some files for the test.

[baltzell]

Were there CCDB tables recently updated that are required for this?

[cpaudel]

Hi Nathan: Yes, new constants were uploaded today and can be found at /calibration/alert/ahdc/gains. Sincerely Churamani

…

________________________________ From: Nathan Baltzell ***@***.***> Sent: Thursday, December 11, 2025 5:27 PM To: JeffersonLab/coatjava ***@***.***> Cc: Churamani Paudel ***@***.***>; Author ***@***.***> Subject: Re: [JeffersonLab/coatjava] AHDC: apply ADC gain calibration from /calibration/alert/ahdc/gains (PR #1003) You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> WARNING This email originated external to the NMSU email system. Do not click on links or open attachments unless you are sure the content is safe. [https://avatars.githubusercontent.com/u/6279258?s=20&v=4]baltzell left a comment (JeffersonLab/coatjava#1003)<#1003 (comment)> Were there CCDB tables recently updated that are required for this? — Reply to this email directly, view it on GitHub<#1003 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B3M7EGFO3Y3M4DPFFNH2NGD4BIDVXAVCNFSM6AAAAACOZH5UZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNBUGM3TGOJYHE>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[churamani2030dev]

Yes, new constants were uploaded today and can be found at /calibration/alert/ahdc/gains.

link is below:

(https://clasweb.jlab.org/cgi-bin/ccdb/show_request?request=/calibration/alert/ahdc/gains:0:default:2025-12-11_12-32-07)

[baltzell]

The CCDB changes will propagate to CVMFS shortly and we'll retrigger the tests.

[churamani2030dev]

removed the "try catch" option for the absense of TOT table and set the requirement for table to be present in the ccdb

[cpaudel]

removed the "try catch" option for the absense of TOT table and set the requirement for table to be present in the ccdb

[cpaudel]

Hi Nathan: May be this is can be done then: IndexedTable ahdc_totGains = manager.getConstants(...); if (ahdc_totGains == null) { ... } can be replaced by Can be replaced by IndexedTable ahdc_totGains = manager.getConstants(runno, "/calibration/alert/ahdc/tot_gains"); So that fails naturally. Sincerely Churamani

________________________________ From: Nathan Baltzell ***@***.***> Sent: Tuesday, December 16, 2025 8:28 AM To: JeffersonLab/coatjava ***@***.***> Cc: Churamani Paudel ***@***.***>; Author ***@***.***> Subject: Re: [JeffersonLab/coatjava] AHDC: apply ADC gain calibration from /calibration/alert/ahdc/gains (PR #1003) WARNING This email originated external to the NMSU email system. Do not click on links or open attachments unless you are sure the content is safe. @baltzell commented on this pull request.

________________________________ In reconstruction/alert/src/main/java/org/jlab/rec/alert/constants/CalibrationConstantsLoader.java<#1003 (comment)>:

+ public static Map<Integer, double[]> ATOF_ATTENUATION_LENGTH = new HashMap<>(); ///< ATOF attenuation length

+ public static Map<Integer, double[]> ATOF_TIME_OFFSETS = new HashMap<>(); ///< ATOF timing offsets + + public static synchronized void Load(int runno, ConstantsManager manager) { + + if (CSTLOADED) return; + + // --- AHDC tables from CCDB (all required) --- + IndexedTable ahdc_timeOffsets = manager.getConstants(runno, "/calibration/alert/ahdc/time_offsets"); + IndexedTable ahdc_time2distance = manager.getConstants(runno, "/calibration/alert/ahdc/time_to_distance"); + IndexedTable ahdc_rawHitCuts = manager.getConstants(runno, "/calibration/alert/ahdc/raw_hit_cuts"); + IndexedTable ahdc_adcGains = manager.getConstants(runno, "/calibration/alert/ahdc/gains"); + + // TOT gain table is now treated as a REQUIRED table. + IndexedTable ahdc_totGains = manager.getConstants(runno, "/calibration/alert/ahdc/tot_gains"); + if (ahdc_totGains == null) { No need to treat this one specially. — Reply to this email directly, view it on GitHub<#1003 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/B3M7EGHGJKG3YF7OJQ6STGT4CAQKTAVCNFSM6AAAAACOZH5UZSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKOBTG4YDAMJZGA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[ftouchte]

Apart from the above comments, the code works well for simulation.

[baltzell]

@ftouchte can you approve this?

[ftouchte]

@baltzell Do you think I should resolve all my comments? I can fix them in my next PR (I plan to extend the AHDC::hits bank).

[churamani2030dev]

@ftouchte
So I need to work those errors right? In order to fully pass all the checks.

Errors:
Error: AHDCTest.run:27 » NullPointer Cannot invoke "org.jlab.utils.groups.IndexedTable.getRowCount()" because "ahdc_timeOverThreshold" is null
[INFO]
Error: Tests run: 2, Failures: 0, Errors: 1, Skipped: 0

[cpaudel]

@ftouchte: tried to resolve the comments, edited the code and committed the changes.

[baltzell]

@ftouche, I really just meant that ideally someone other than me, someone more familiar with AHDC's code and strategy should click approve.