Skip to content

AHDC: apply ADC gain calibration from /calibration/alert/ahdc/gains #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baltzell merged 10 commits into from
Dec 17, 2025
Merged

AHDC: apply ADC gain calibration from /calibration/alert/ahdc/gains #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
812712d
AHDC: apply ADC gain calibration from /calibration/alert/ahdc/gains
Dec 11, 2025
c7fcb08
column match with ccdb table
Dec 12, 2025
cb5f1b4
switch to AI-Track-Finding model
Dec 12, 2025
9ab0df8
update applied for TOT, consistent with adc gains
Dec 12, 2025
a6b77a1
review gains and tot table
Dec 17, 2025
f1e783c
AHDC: fail fast when calibration constants missing
Dec 17, 2025
b21d8ac
AHDC: fail fast when calibration constants missing
Dec 17, 2025
7e9396b
resolve comments
Dec 17, 2025
be79725
AHDC: handle missing time_over_threshold CCDB table
Dec 17, 2025
afd7835
Merge branch 'development' into ahdc-adc-gain-calib
cpaudel Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reconstruction/alert/src/main/java/org/jlab/rec/ahdc/AI/ModelTrackFinding.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public NDList processInput(TranslatorContext translatorContext, float[] floats)
.optTranslator(my_translator)
.optProgress(new ProgressBar())
.build();


try {
model = my_model.loadModel();
Expand Down
312 changes: 197 additions & 115 deletions reconstruction/alert/src/main/java/org/jlab/rec/ahdc/Hit/HitReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,119 +10,201 @@

public class HitReader {

private ArrayList<Hit> _AHDCHits;
private ArrayList<TrueHit> _TrueAHDCHits;
private boolean sim = false;

public HitReader(DataEvent event, AlertDCDetector detector, boolean simulation) {
sim = simulation;
fetch_AHDCHits(event, detector);
if (simulation) fetch_TrueAHDCHits(event);
}

public final void fetch_AHDCHits(DataEvent event, AlertDCDetector detector) {
ArrayList<Hit> hits = new ArrayList<>();


if (event.hasBank("AHDC::adc")) {
// Useful if one does not run the full CLAS12 reconstrcution
// i.e only run the reconstruction of ALERT
// or use simulated data
double startTime = 0;
if (event.hasBank("REC::Event") && !sim) {
DataBank bankRecEvent = event.getBank("REC::Event");
startTime = bankRecEvent.getFloat("startTime", 0);
}

RawDataBank bankDGTZ = new RawDataBank("AHDC::adc");
bankDGTZ.read(event);

for (int i = 0; i < bankDGTZ.rows(); i++) {
int id = bankDGTZ.trueIndex(i) + 1;
int number = bankDGTZ.getByte("layer", i);
int layer = number % 10;
int superlayer = (int) (number % 100) / 10;
int sector = bankDGTZ.getInt("sector", i);
int wire = bankDGTZ.getShort("component", i);
double adc = bankDGTZ.getInt("ADC", i);
double leadingEdgeTime = bankDGTZ.getFloat("leadingEdgeTime", i);
double timeOverThreshold = bankDGTZ.getFloat("timeOverThreshold", i);
double adcOffset = bankDGTZ.getFloat("ped", i);
int wfType = bankDGTZ.getShort("wfType", i);
// Retrieve raw hit cuts from CCDB
int key_value = sector*10000 + number*100 + wire;
double[] rawHitCuts = CalibrationConstantsLoader.AHDC_RAW_HIT_CUTS.get( key_value );
double t_min = rawHitCuts[0];
double t_max = rawHitCuts[1];
double tot_min = rawHitCuts[2];
double tot_max = rawHitCuts[3];
double adc_min = rawHitCuts[4];
double adc_max = rawHitCuts[5];
double ped_min = rawHitCuts[6];
double ped_max = rawHitCuts[7];
//System.out.println("t_min : " + t_min + " t_max : " + t_max + " tot_min : " + tot_min + " tot_max : " + tot_max + " adc_min : " + adc_min + " adc_max : " + adc_max + " ped_min : " + ped_min + " ped_max : " + ped_max);
// Retrieve t0 and t2d from CCDB
// What's about simulation?
double[] timeOffsets = CalibrationConstantsLoader.AHDC_TIME_OFFSETS.get( key_value );
double[] time2distance = CalibrationConstantsLoader.AHDC_TIME_TO_DISTANCE.get( 10101 ); // the time to distance table has only one row ! (10101 is its only key)
double t0 = timeOffsets[0];
double p0 = time2distance[0];
double p1 = time2distance[1];
double p2 = time2distance[2];
double p3 = time2distance[3];
double p4 = time2distance[4];
double p5 = time2distance[5];
// Apply time calibration
// We may need adc calibration too
// Remark: leadingEdgeTime already has the fine timestamp correction
double time = leadingEdgeTime - t0 - startTime;

// Hit selection : wfType and additional cuts
if (((wfType <= 2) && (adc >= adc_min) && (adc <= adc_max) && (time >= t_min) && (time <= t_max) && (timeOverThreshold >= tot_min) && (timeOverThreshold <= tot_max) && (adcOffset >= ped_min) && (adcOffset <= ped_max)) || sim) {
double doca = p0 + p1*Math.pow(time,1.0) + p2*Math.pow(time,2.0) + p3*Math.pow(time,3.0) + p4*Math.pow(time,4.0) + p5*Math.pow(time, 5.0);
if (time < 0) doca = 0;
Hit h = new Hit(id, superlayer, layer, wire, doca, adc, time);
h.setWirePosition(detector);
hits.add(h);
}
}
}
this.set_AHDCHits(hits);
}

public final void fetch_TrueAHDCHits(DataEvent event) {
ArrayList<TrueHit> truehits = new ArrayList<>();

DataBank bankSIMU = event.getBank("MC::True");

if (event.hasBank("MC::True")) {
for (int i = 0; i < bankSIMU.rows(); i++) {
int pid = bankSIMU.getInt("pid", i);
double x_true = bankSIMU.getFloat("avgX", i);
double y_true = bankSIMU.getFloat("avgY", i);
double z_true = bankSIMU.getFloat("avgZ", i);
double trackE = bankSIMU.getFloat("trackE", i);

truehits.add(new TrueHit(pid, x_true, y_true, z_true, trackE));
}
}
this.set_TrueAHDCHits(truehits);
}

public ArrayList<Hit> get_AHDCHits() {
return _AHDCHits;
}

public void set_AHDCHits(ArrayList<Hit> _AHDCHits) {
this._AHDCHits = _AHDCHits;
}

public ArrayList<TrueHit> get_TrueAHDCHits() {
return _TrueAHDCHits;
}

public void set_TrueAHDCHits(ArrayList<TrueHit> _TrueAHDCHits) {
this._TrueAHDCHits = _TrueAHDCHits;
}

private ArrayList<Hit> _AHDCHits;
private ArrayList<TrueHit> _TrueAHDCHits;
private boolean sim = false;

public HitReader(DataEvent event, AlertDCDetector detector, boolean simulation) {
sim = simulation;
fetch_AHDCHits(event, detector);
if (simulation) fetch_TrueAHDCHits(event);
}

public final void fetch_AHDCHits(DataEvent event, AlertDCDetector detector) {

ArrayList<Hit> hits = new ArrayList<>();

if (!event.hasBank("AHDC::adc")) {
this.set_AHDCHits(hits);
return;
}

double startTime = 0.0;
if (event.hasBank("REC::Event") && !sim) {
DataBank bankRecEvent = event.getBank("REC::Event");
startTime = bankRecEvent.getFloat("startTime", 0);
}

RawDataBank bankDGTZ = new RawDataBank("AHDC::adc");
bankDGTZ.read(event);

for (int i = 0; i < bankDGTZ.rows(); i++) {

int id = bankDGTZ.trueIndex(i) + 1;
int number = bankDGTZ.getByte("layer", i); // e.g. 11,12,21,... (this matches CCDB "layer")
int layer = number % 10;
int superlayer = (number % 100) / 10;
int sector = bankDGTZ.getInt("sector", i);
int wire = bankDGTZ.getShort("component", i);

// RAW quantities from bank
double adcRaw = bankDGTZ.getInt("ADC", i);
double leadingEdgeTime = bankDGTZ.getFloat("leadingEdgeTime", i);
double timeOverThreshold = bankDGTZ.getFloat("timeOverThreshold", i);
double adcOffset = bankDGTZ.getFloat("ped", i);
int wfType = bankDGTZ.getShort("wfType", i);

// CCDB key
int key_value = sector * 10000 + number * 100 + wire;

// -----------------------------
// Raw hit cuts
// -----------------------------
// double[] rawHitCuts = CalibrationConstantsLoader.AHDC_RAW_HIT_CUTS.get(key_value);
//if (rawHitCuts == null) continue;


double[] rawHitCuts = CalibrationConstantsLoader.AHDC_RAW_HIT_CUTS.get(key_value);
if (rawHitCuts == null) {throw new IllegalStateException("Missing CCDB table /calibration/alert/ahdc/raw_hit_cuts for key=" + key_value+ " (check run/variation + key mapping)");
}

double t_min = rawHitCuts[0];
double t_max = rawHitCuts[1];
double tot_min = rawHitCuts[2];
double tot_max = rawHitCuts[3];
double adc_min = rawHitCuts[4];
double adc_max = rawHitCuts[5];
double ped_min = rawHitCuts[6];
double ped_max = rawHitCuts[7];

// -----------------------------
// Time calibration + t->d
// -----------------------------
//double[] timeOffsets = CalibrationConstantsLoader.AHDC_TIME_OFFSETS.get(key_value);
//if (timeOffsets == null) continue;

// double[] timeOffsets = CalibrationConstantsLoader.AHDC_TIME_OFFSETS.get(key_value);
//if (timeOffsets == null) {
//throw new IllegalStateException("Missing AHDC time_offsets for key=" + key_value);
//}

double[] timeOffsets = CalibrationConstantsLoader.AHDC_TIME_OFFSETS.get(key_value);

if (timeOffsets == null) {
throw new IllegalStateException("Missing CCDB /calibration/alert/ahdc/time_offsets for key=" + key_value + " (check run/variation + key mapping)");
}




double[] time2distance = CalibrationConstantsLoader.AHDC_TIME_TO_DISTANCE.get(10101);
if (time2distance == null) continue;

double t0 = timeOffsets[0];

double p0 = time2distance[0];
double p1 = time2distance[1];
double p2 = time2distance[2];
double p3 = time2distance[3];
double p4 = time2distance[4];
double p5 = time2distance[5];

double time = leadingEdgeTime - t0 - startTime;

// -----------------------------
// ToT correction (new CCDB)
// convention: ToT_corr = ToT_raw * totCorr
// -----------------------------
double totUsed = timeOverThreshold;
if (!sim) {
double[] totArr = CalibrationConstantsLoader.AHDC_TIME_OVER_THRESHOLD.get(key_value);
if (totArr != null && totArr.length > 0) {
double totCorr = totArr[0];
totUsed = timeOverThreshold * totCorr;
}
}

// -----------------------------
// Hit selection (cuts)
// NOTE: we cut on totUsed (corrected ToT). If you want RAW-ToT cuts,
// replace totUsed with timeOverThreshold in the condition.
// -----------------------------
boolean passCuts =
(wfType <= 2) &&
(adcRaw >= adc_min) && (adcRaw <= adc_max) &&
(time >= t_min) && (time <= t_max) &&
(timeOverThreshold >= tot_min) && (timeOverThreshold <= tot_max)&&
//(totUsed >= tot_min) && (totUsed <= tot_max) &&
(adcOffset >= ped_min) && (adcOffset <= ped_max);

if (!passCuts && !sim) continue;

// -----------------------------
// DOCA from calibrated time
// -----------------------------
double doca = p0
+ p1*Math.pow(time, 1.0)
+ p2*Math.pow(time, 2.0)
+ p3*Math.pow(time, 3.0)
+ p4*Math.pow(time, 4.0)
+ p5*Math.pow(time, 5.0);

if (time < 0) doca = 0.0;

// -----------------------------
// ADC gain calibration (new gains schema: gainCorr is index 0)
// convention: ADC_cal = ADC_raw * gainCorr
// -----------------------------
double adcCal = adcRaw;
if (!sim) {
double[] gainArr = CalibrationConstantsLoader.AHDC_ADC_GAINS.get(key_value);
if (gainArr != null && gainArr.length > 0) {
double gainCorr = gainArr[0];
adcCal = adcRaw * gainCorr;
}
}

Hit h = new Hit(id, superlayer, layer, wire, doca, adcCal, time);
h.setWirePosition(detector);
hits.add(h);
}

this.set_AHDCHits(hits);
}

public final void fetch_TrueAHDCHits(DataEvent event) {

ArrayList<TrueHit> truehits = new ArrayList<>();

if (event.hasBank("MC::True")) {
DataBank bankSIMU = event.getBank("MC::True");
for (int i = 0; i < bankSIMU.rows(); i++) {
int pid = bankSIMU.getInt("pid", i);
double x_true = bankSIMU.getFloat("avgX", i);
double y_true = bankSIMU.getFloat("avgY", i);
double z_true = bankSIMU.getFloat("avgZ", i);
double trackE = bankSIMU.getFloat("trackE", i);

truehits.add(new TrueHit(pid, x_true, y_true, z_true, trackE));
}
}

this.set_TrueAHDCHits(truehits);
}

public ArrayList<Hit> get_AHDCHits() {
return _AHDCHits;
}

public void set_AHDCHits(ArrayList<Hit> hits) {
this._AHDCHits = hits;
}

public ArrayList<TrueHit> get_TrueAHDCHits() {
return _TrueAHDCHits;
}

public void set_TrueAHDCHits(ArrayList<TrueHit> trueHits) {
this._TrueAHDCHits = trueHits;
}
}
Loading