ci: fix Julia 1.6 failure on macOS-latest (ARM64)#61
ci: fix Julia 1.6 failure on macOS-latest (ARM64)#61amemya wants to merge 3 commits intoJuliaAudio:masterfrom
Conversation
…and update GitHub Actions to their latest versions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 91.58% 91.83% +0.25%
==========================================
Files 6 6
Lines 202 196 -6
==========================================
- Hits 185 180 -5
+ Misses 17 16 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI failure where Julia 1.6 tests were failing on macOS-latest runners, which now use ARM64 architecture. Julia 1.6 does not provide official binaries for macOS ARM64, causing the test failures.
Changes:
- Adds matrix exclusions to prevent Julia 1.6 from running on macOS-latest and to exclude x86 architecture on macOS-latest
- Updates GitHub Actions to newer versions (checkout@v4, setup-julia@v2, codecov@v5)
- Adds explicit
archparameter to setup-julia configuration and updates codecov parameter fromfiletofiles
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - version: '1.6' | ||
| os: macOS-latest |
There was a problem hiding this comment.
This exclusion completely removes Julia 1.6 testing from macOS. According to the issue description, Julia 1.6 supports x86_64 on macOS - it just doesn't support ARM64.
Consider using an Intel-based macOS runner (like macos-13) for Julia 1.6 instead of excluding it entirely. This would maintain test coverage for Julia 1.6 on macOS while avoiding the ARM64 compatibility issue. For example, you could add macos-13 to the os matrix and use an include to specifically pair Julia 1.6 with macos-13.
|
It seems the CI is failing only on 32-bit (x86). This is caused by a type mismatch: on x86, the I will fix this by explicitly casting the |
|
I looked into why the 32-bit tests suddenly started failing. |
|
okay, all ci tests passed. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| function _seek(source::SndFileSource, offset::Integer, whence::Integer) | ||
| new_offset = sf_seek(source.filePtr, offset, whence) | ||
| new_offset = sf_seek(source.filePtr, sf_count_t(offset), whence) |
There was a problem hiding this comment.
This change to add an explicit sf_count_t() type conversion in _seek is not mentioned in the PR description and appears unrelated to fixing the CI failure on macOS ARM64. The PR title and description focus exclusively on fixing the Julia 1.6 macOS CI issue.
If this is a separate bug fix or improvement (possibly related to type stability or compatibility), it should either be:
- Mentioned in the PR description and explained, or
- Moved to a separate PR
This helps maintain clear, focused changes and makes it easier to track what was changed and why.
1 participant
Fixes #60
Summary
Fixes the CI failure where the
macos-latestrunner (now ARM64) attempts to run Julia 1.6.Since Julia 1.6 does not provide official binaries for macOS ARM64, this PR updates the workflow matrix to exclude the combination of
Julia 1.6andmacOS-latest.Changes
.github/workflows/tests.yml:version: 1.6onos: macOS-latestto avoid architecture mismatch.archis correctly passed tosetup-julia.